Skip to content

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Sep 25, 2025

Description

When 2 providers offer the same model but have different api limitations/params e.g. context length etc conflicts can arise. Should try to find info in provider and then fall back.
Fixes https://github.com/continuedev/continue/actions/runs/17993730030/job/51188936181


Summary by cubic

Fixes model info conflicts when multiple providers expose the same model by preferring the active provider during lookup. Ensures correct limits and templates are applied.

  • Bug Fixes
    • findLlmInfo now accepts a preferProviderId and searches that provider first, then falls back.
    • BaseLLM passes underlyingProviderName to findLlmInfo to select the right provider’s model info.

@RomneyDa RomneyDa requested a review from a team as a code owner September 25, 2025 01:22
@RomneyDa RomneyDa requested review from tingwai and removed request for a team September 25, 2025 01:22
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 25, 2025
Copy link

⚠️ AI review completed but no review output was generated. Check the action logs for details.


💡 To request a new review, comment @continue-general-review

sestinj
sestinj previously approved these changes Sep 25, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 25, 2025
Copy link

AI Code Review

AI review failed due to service initialization issues. Please check the Continue API key and configuration.

No specific line comments generated.


💡 To request a new detailed review, comment @continue-detailed-review

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 25, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="packages/llm-info/src/index.ts">

<violation number="1" location="packages/llm-info/src/index.ts:44">
Returning the provider-specific model without provider causes inconsistent runtime shape; include provider on this path for consistency.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@Patrick-Erichsen Patrick-Erichsen merged commit 306ed9f into main Sep 25, 2025
110 of 119 checks passed
@Patrick-Erichsen Patrick-Erichsen deleted the dallin/llm-info-grok-conflict branch September 25, 2025 21:12
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Sep 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2025
@sestinj
Copy link
Contributor

sestinj commented Sep 26, 2025

🎉 This PR is included in version 1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer released size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants