chore: remove chat history from redux persistent storage #7944
Conversation
dosubot
bot
added
the
size:S
There was a problem hiding this comment.
@uinstinct when I tried this earlier it caused failure to load last session, do we need to add loading of last session on startup from JSON?
dosubot
bot
added
size:M
I see. There is a slight delay on the first load. feat.mp4 |
|
@uinstinct I mean on startup it won't load the last session like it currently does. The last session button would operate as before |
feat.mp4implemented! |
| export function setupStore(options: { ideMessenger?: IIdeMessenger }) { | ||
| const ideMessenger = options.ideMessenger ?? new IdeMessenger(); | ||
|
|
||
| const logger = createLogger({ |
There was a problem hiding this comment.
This can be used if you uncomment the .concat(logger) below. For debugging
| createFilter("session", [ | ||
| "history", | ||
| "id", | ||
| "lastSessionId", |
There was a problem hiding this comment.
We still need to persist lastSessionId
| async (_, { extra, dispatch, getState }) => { | ||
| let lastSessionId = getState().session.lastSessionId; | ||
|
|
||
| const lastSessionResult = await extra.ideMessenger.request("history/list", { |
There was a problem hiding this comment.
I would just used persisted lastSessionId still rather than listing history. If there's noLast sessionId we start a new session
There was a problem hiding this comment.
That being said might just comment it out since we will want some version of this soon for per-workspace sessions!
| }, []); | ||
|
|
||
| useEffect(() => { | ||
| void dispatch(loadLastSession()); |
There was a problem hiding this comment.
Since this is pretty critical loading could we add some retry logic and error handling? Maybe retry with exponential backoff or a few times or similar
Description
Remove session reducer's history item from redux's persistent storage which was stored in vscode's session storage (having cases exceeding 5mb limit).
closes CON-3773
AI Code Review
@continue-general-reviewor@continue-detailed-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Removed persisting chat history in Redux to VS Code session storage to avoid hitting the 5 MB limit and prevent errors on large sessions. Closes CON-3773.
Bug Fixes
Refactors