Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 18 additions & 24 deletions .github/actions/build-vscode-extension/action.yml
Original file line number Diff line number Diff line change
@@ -1,49 +1,49 @@
name: 'Build VS Code Extension'
description: 'Build VS Code extension for a specific platform'
name: "Build VS Code Extension"
description: "Build VS Code extension for a specific platform"
inputs:
platform:
description: 'Target platform (win32, linux, alpine, darwin)'
description: "Target platform (win32, linux, alpine, darwin)"
required: true
arch:
description: 'Target architecture (x64, arm64, armhf)'
description: "Target architecture (x64, arm64, armhf)"
required: true
npm_config_arch:
description: 'npm config arch (x64, arm64, arm)'
description: "npm config arch (x64, arm64, arm)"
required: true
pre-release:
description: 'Whether to build as pre-release'
description: "Whether to build as pre-release"
required: false
default: 'false'
default: "false"
commit-sha:
description: 'Commit SHA for version modification (optional, uses first 7 chars)'
description: "Commit SHA for version modification (optional, uses first 7 chars)"
required: false
default: ''
default: ""
github-token:
description: 'GitHub token for downloading ripgrep'
description: "GitHub token for downloading ripgrep"
required: true
outputs:
target:
description: 'The target string used for the build'
description: "The target string used for the build"
value: ${{ steps.set-target.outputs.target }}
vsix-path:
description: 'Path to the generated VSIX file'
value: 'extensions/vscode/*.vsix'
description: "Path to the generated VSIX file"
value: "extensions/vscode/*.vsix"
build-path:
description: 'Path to the build artifacts'
value: 'extensions/vscode/build'
description: "Path to the build artifacts"
value: "extensions/vscode/build"

runs:
using: 'composite'
using: "composite"
steps:
- uses: actions/setup-node@v4
with:
node-version-file: ".nvmrc"

- name: Set target variable
id: set-target
shell: bash
run: echo "target=${{ inputs.platform }}-${{ inputs.arch }}" >> $GITHUB_OUTPUT

- name: Cache npm
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -115,12 +115,6 @@ runs:
cd extensions/vscode
npm run prepackage -- --target ${{ steps.set-target.outputs.target }}

- name: Re-install esbuild
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is the same esbuild as the one used for config.ts

shell: bash
run: |
cd extensions/vscode
npm install -f esbuild

- name: Modify package.json version with commit SHA
if: inputs.commit-sha != ''
shell: bash
Expand Down
5 changes: 2 additions & 3 deletions binary/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,14 @@ The build process is otherwise defined entirely in `build.js`.

- sqlite3/build/Release/node_sqlite3.node (\*)
- @lancedb/\*\*
- esbuild?
- @esbuild?
- esbuild? <!-- still bundled, no @esbuild/* packages -->
- onnxruntime-node?

### List of dynamically imported modules

- posthog-node
- @octokit/rest
- esbuild
- esbuild <!-- build-time only -->

### List of .wasm files

Expand Down
2 changes: 1 addition & 1 deletion binary/utils/bundle-binary.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const { TARGET_TO_LANCEDB } = require("../utils/targets");
const fs = require("fs");
const {
downloadSqlite,
} = require("../../extensions/vscode/scripts/download-copy-sqlite-esbuild");
} = require("../../extensions/vscode/scripts/download-copy-sqlite");
const { fork } = require("child_process");

async function downloadNodeSqlite(target, targetDir) {
Expand Down
55 changes: 0 additions & 55 deletions core/config/ConfigHandler.vitest.ts

This file was deleted.

Loading
Loading