Skip to content

Conversation

aadarshkt
Copy link
Contributor

@aadarshkt aadarshkt commented Aug 17, 2025

Description

Fix : Image drop feature from main editor.

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-general-review or @continue-detailed-review

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screen recording or screenshot

Error screen recording.

not-working-shorter-1.mov

Working screen recording -

Image-drop-feature-working-1.mov

Tests

N/A


Summary by cubic

Fixes image drag-and-drop in the main editor. You can now drop image files or images from VS Code and they insert correctly.

  • Bug Fixes
    • Added a readFileAsDataUrl IDE protocol and VS Code handler to read dropped images and return a data URL (png/jpeg).
    • TipTap now intercepts VS Code resource URLs on drop/paste, prevents default handling, and inserts the image using a data URL.
    • Handles both file drops and HTML drops from VS Code by normalizing to data URLs and inserting the image at the start.
    • Drag overlay no longer blocks pointer events; drop explicitly prevents default to avoid double-handling.

Copy link

github-actions bot commented Aug 17, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@aadarshkt
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@RomneyDa
Copy link
Collaborator

RomneyDa commented Sep 8, 2025

@aadarshkt looking through PRs, can you update this if it's ready for review?

@aadarshkt
Copy link
Contributor Author

Sure. Few more changes required. It will take few days.

@aadarshkt
Copy link
Contributor Author

Added support for multiple image and prevent default image processing which is failing.

multiple-image-support.mov

@aadarshkt aadarshkt marked this pull request as ready for review September 10, 2025 15:46
@aadarshkt aadarshkt requested a review from a team as a code owner September 10, 2025 15:46
@aadarshkt aadarshkt requested review from sestinj and removed request for a team September 10, 2025 15:46
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 10, 2025
Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! will merge once tests pass

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 22, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 22, 2025
@sestinj sestinj merged commit f859010 into continuedev:main Sep 22, 2025
53 of 54 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Sep 22, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2025
@sestinj
Copy link
Contributor

sestinj commented Sep 22, 2025

🎉 This PR is included in version 1.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@continuedev continuedev unlocked this conversation Sep 22, 2025
@RomneyDa
Copy link
Collaborator

@aadarshkt note this PR was reverted here
#7908
Because of the extraneous build script changes which broke debugging

@RomneyDa
Copy link
Collaborator

reopened here
#7910

pull bot pushed a commit to KornaAI/continue that referenced this pull request Sep 22, 2025
@sestinj
Copy link
Contributor

sestinj commented Sep 26, 2025

🎉 This PR is included in version 1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer released size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants