Skip to content

fix: remove reject edit diff functionality on cmd backspace #6703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025

Conversation

uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Jul 18, 2025

Description

When cmd+backspace was pressed to delete entire words in the chat area on edit mode, the focus would transfer to the editor which in turn would delete words from the editor. This PR fixes this behavior by removing the "reject diff" shortcut functionality from edit mode.

  • remove "rejectDiff" on cmd backspace event listener

resolves CON-2607

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screenshots

before.mp4
after.mp4

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Removed the "reject diff" shortcut from edit mode so pressing cmd+backspace in the chat area no longer deletes words in the editor.

@uinstinct uinstinct requested a review from a team as a code owner July 18, 2025 14:23
@uinstinct uinstinct requested review from Patrick-Erichsen and removed request for a team July 18, 2025 14:23
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 18, 2025
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there another shortcut that can be used to reject? If not let's try fixing it instead of removing it.

Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jul 18, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 18, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit 46b6448 into continuedev:main Jul 18, 2025
73 of 75 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jul 18, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2025
@uinstinct uinstinct deleted the cmd-backspace-edit branch July 18, 2025 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants