fix: restore invalid config error reporting #6679
Merged
+116
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fred Bricon <[email protected]>
dosubot
bot
added
the
size:L
RomneyDa
approved these changes
Jul 18, 2025
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
17000f4 broke error configuration reporting, i.e. if a config file contains invalid YAML (according to YAML parsing rules or the validation schema), no error is reported on the Continue view. The error is swallowed in a catch block while trying to parse the content as markdown, which always returns a result.
This PR fixes this issue, by checking, in the event YAML parsing fails, we don't fall back to markdown parsing if the config file ends with yaml or yml.
Summary by cubic
Fixed a bug where invalid YAML config files did not show error messages in the Continue view. Now, errors are reported if a YAML or YML config file fails to parse, instead of silently falling back to markdown parsing.