-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit tool + Create tool tweaks #4978
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for continuedev canceled.
|
Closed
Closed
Patrick-Erichsen
previously approved these changes
Apr 5, 2025
sestinj
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updateApplyState
messages for JetbrainsOriginally (see 4683a20) I enabled core to initiate
applyToFile
within a core-side edit tool implementation, and generated a stream id on GUI that was passed to core and then around from there. The main issue with this was a lack of stateful awareness of diffs in core before passing tool output back to model. I found this to be a bad user experience.I ended up deciding that it's okay to have a custom Edit tool implementation in GUI that bypasses the other tools. This opens up channels for potential tools like a "new session" tool that would also be GUI-only. I added
toolCallId
to Apply state so that apply streams can optionally be associated with tool calls.