Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit tool + Create tool tweaks #4978

Merged
merged 22 commits into from
Apr 5, 2025
Merged

Edit tool + Create tool tweaks #4978

merged 22 commits into from
Apr 5, 2025

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Apr 4, 2025

Description

  • Adds lazy apply with updateApplyState messages for Jetbrains
  • Edit tool with custom tool call UI and accept/reject buttons
  • Disables submitting tip tap editors while this apply states are pending (for now)
  • error if attempting to create file that already exists. This is important because right now it overwrites in a way that is not undo-able, and this is bad regardless of if an edit tool is available
  • Both create and edit tool call UIs hide the codeblock toolbar apply button
  • Fixes generating logic error causing multiple codeblocks to show generating

Originally (see 4683a20) I enabled core to initiate applyToFile within a core-side edit tool implementation, and generated a stream id on GUI that was passed to core and then around from there. The main issue with this was a lack of stateful awareness of diffs in core before passing tool output back to model. I found this to be a bad user experience.

I ended up deciding that it's okay to have a custom Edit tool implementation in GUI that bypasses the other tools. This opens up channels for potential tools like a "new session" tool that would also be GUI-only. I added toolCallId to Apply state so that apply streams can optionally be associated with tool calls.

Copy link

netlify bot commented Apr 4, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit f2237c0
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67f074f58c53200008eb30a7

@RomneyDa RomneyDa changed the title DRAFT - Edit tools DRAFT - Edit tool Apr 4, 2025
@RomneyDa RomneyDa mentioned this pull request Apr 4, 2025
@RomneyDa RomneyDa marked this pull request as ready for review April 4, 2025 10:17
@RomneyDa RomneyDa requested a review from a team as a code owner April 4, 2025 10:17
@RomneyDa RomneyDa requested review from sestinj and removed request for a team April 4, 2025 10:17
@RomneyDa RomneyDa changed the title DRAFT - Edit tool Edit tool Apr 4, 2025
@RomneyDa RomneyDa changed the title Edit tool Edit tool + Create tool tweaks Apr 4, 2025
@RomneyDa RomneyDa mentioned this pull request Apr 4, 2025
@RomneyDa RomneyDa merged commit 3939b5b into main Apr 5, 2025
31 checks passed
@RomneyDa RomneyDa deleted the dallin/create-edit branch April 5, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants