-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ApiKey to TEI embedding provider #4783
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for continuedev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YohannZe I believe this was fixed 2 weeks ago around the same time as your PR was opened on #4581. Sorry for the review delay.
apiKey
is added to headers in the this.fetch
function that uses our custom @continuedev/fetch
package to apply request options to the request. Huggingface was using fetch
instead of this.fetch
. Your approach would also fix the api key but other request options would still be ignored.
Could you verify that this has been fixed on your end?
Hello @RomneyDa , thanks for the reply ! I've read your PR, could it be that in it HuggingFaceTei extends BaseLLM where it should extend openAI ? I'm not familiar with the code so I could be wrong. Thanks for the review, I remain available if anything. |
OpenAI extends BaseLLM and |
Description
[ What changed? Feel free to be brief. ]
Added the possibility to have an api-key in the tei embedding provider, following what was done for the rerank endpoint.
Checklist
Screenshots
[ For visual changes, include screenshots. ]
Testing instructions
[ For new or modified features, provide step-by-step testing instructions to validate the intended behavior of the change, including any relevant tests to run. ]