Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect typing for unresolved links for taxonomy [] #2401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/types/concept-scheme.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Link } from './link'
import { UnresolvedLink } from './link'
import { LocaleCode } from './locale'

type ISODateString = string
Expand All @@ -22,8 +22,8 @@ export interface ConceptScheme<Locales extends LocaleCode> {
[locale in Locales]: string
}
| null
topConcepts: Link<'TaxonomyConcept'>[]
concepts: Link<'TaxonomyConcept'>[]
topConcepts: UnresolvedLink<'TaxonomyConcept'>[]
concepts: UnresolvedLink<'TaxonomyConcept'>[]
totalConcepts: number
}

Expand Down
6 changes: 3 additions & 3 deletions lib/types/concept.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Link } from './link'
import { UnresolvedLink } from './link'
import { LocaleCode } from './locale'

type ISODateString = string
Expand Down Expand Up @@ -59,8 +59,8 @@ export interface Concept<Locales extends LocaleCode> {
}
| null
notations?: string[]
broader?: Link<'TaxonomyConcept'>[]
related?: Link<'TaxonomyConcept'>[]
broader?: UnresolvedLink<'TaxonomyConcept'>[]
related?: UnresolvedLink<'TaxonomyConcept'>[]
}

export type ConceptCollection<Locale extends LocaleCode> = {
Expand Down