Skip to content

Comments

No merge: Initial BMFF embeddable support experiment#1808

Open
mauricefisher64 wants to merge 2 commits intomainfrom
emeddable_bmff
Open

No merge: Initial BMFF embeddable support experiment#1808
mauricefisher64 wants to merge 2 commits intomainfrom
emeddable_bmff

Conversation

@mauricefisher64
Copy link
Collaborator

Changes in this pull request

Give a narrative description of what has been changed.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

…eddable_bmff

# Conflicts:
#	c2pa_c_ffi/src/c_api.rs
#	sdk/src/builder.rs
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 61.40351% with 132 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.52%. Comparing base (bc3f735) to head (530d394).

Files with missing lines Patch % Lines
sdk/src/assertions/bmff_hash.rs 36.44% 68 Missing ⚠️
c2pa_c_ffi/src/c_api.rs 67.39% 30 Missing ⚠️
sdk/src/store.rs 73.33% 20 Missing ⚠️
sdk/src/utils/hash_utils.rs 30.76% 9 Missing ⚠️
sdk/src/builder.rs 88.09% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1808      +/-   ##
==========================================
- Coverage   76.56%   76.52%   -0.05%     
==========================================
  Files         170      170              
  Lines       39514    39766     +252     
==========================================
+ Hits        30255    30432     +177     
- Misses       9259     9334      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 10, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing emeddable_bmff (530d394) with main (bc3f735)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant