Conversation
CodSpeed Performance ReportMerging #1630 will not alter performanceComparing Summary
Footnotes
|
|
@scouten-adobe @ok-nick |
|
@ok-nick Maybe a suggestion because there is a lot of related work in-flight: Group your PRs into a feature branch (as you sit fit)? So they will be easier to integrate together (since it seems they'll be in the same release too), and maybe easier to maintain while in their rbanch(es). Wdyt? #1630 and #1618 I could see released together. For the rest, developer's choice! |
* feat: foundation for restricted http resolvers * docs: document when outbound network requests occur * fix: consolidate sync and async restricted resolver * docs: document restricted resolvers and patterns * test: add basic restricted resolver tests * fix: optional allowed hosts and refined restricted tests * fix: remove unused code WASM * fix: simplify host pattern implementation * docs: clarify why/how restrict networking and dynamic endpoints * docs: mention remote signer settings invokes network requests * docs: clarify `http` crate exports * docs: clarify returns true * docs: refer to settings * docs: support for IP addresses and ports * fix: add support for ports in allowed lists * fix: support only scheme * test: remove unrelated test image * docs: add new setting to settings.md * docs: add host pattern examples * test: invalid pattern unit test * docs: remove empty line * docs: warn CAWG does not respect this setting yet
Introduces a new
RestrictedResolverstruct to restrict an innerSync/AsyncHttpResolverwith the specified allowed list. For the SDK, this is used specifically with thecore.allowed_network_hostssetting to constrain HTTP requests to a known list of allowed hosts.The default behavior of the SDK is to wrap a
Sync/AsyncGenericResolverwith aRestrictedResolverusing thecore.allowed_network_hostssetting. Eventually HTTP resolvers and settings will be passed in directly as structs.The behavior for
core.allowed_network_hostsis defined as follows: