Skip to content

Test: Log code coverage reports to currents#858

Closed
swadeley wants to merge 3 commits intocontent-services:mainfrom
swadeley:swadeley/code_coverage_log_to_currents
Closed

Test: Log code coverage reports to currents#858
swadeley wants to merge 3 commits intocontent-services:mainfrom
swadeley:swadeley/code_coverage_log_to_currents

Conversation

@swadeley
Copy link
Member

@swadeley swadeley commented Feb 3, 2026

Summary

Log code coverage reports to currents.dev
Bump test-utils from BE PR 1385

Testing steps

tests pass

#testwith content-services/content-sources-backend#1385

sourcery-ai[bot]

This comment was marked as outdated.

Sign in to view

@swadeley swadeley changed the title Test: code coverage log to currents Test: Log code coverage reports to currents.dev Feb 3, 2026
@swadeley swadeley changed the title Test: Log code coverage reports to currents.dev Test: Log code coverage reports to currents Feb 3, 2026
@swadeley swadeley force-pushed the swadeley/code_coverage_log_to_currents branch from 2f91195 to 431339e Compare February 3, 2026 05:09
@swadeley
Copy link
Member Author

swadeley commented Feb 3, 2026

@sourcery-ai dismiss

@swadeley
Copy link
Member Author

swadeley commented Feb 3, 2026

@sourcery-ai review

sourcery-ai[bot]

This comment was marked as outdated.

Sign in to view

@swadeley swadeley force-pushed the swadeley/code_coverage_log_to_currents branch from 431339e to 89cc8a2 Compare February 3, 2026 05:36
@swadeley
Copy link
Member Author

swadeley commented Feb 3, 2026

@sourcery-ai dismiss

@swadeley
Copy link
Member Author

swadeley commented Feb 3, 2026

@sourcery-ai review

sourcery-ai[bot]

This comment was marked as duplicate.

Sign in to view

@swadeley swadeley force-pushed the swadeley/code_coverage_log_to_currents branch from 89cc8a2 to 3f2dac2 Compare February 3, 2026 05:58
@swadeley
Copy link
Member Author

swadeley commented Feb 3, 2026

@sourcery-ai dismiss

@swadeley
Copy link
Member Author

swadeley commented Feb 3, 2026

@sourcery-ai review

sourcery-ai[bot]
sourcery-ai bot reviewed Feb 3, 2026
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dominikvagner dominikvagner self-assigned this Feb 3, 2026
dominikvagner
dominikvagner requested changes Feb 4, 2026
View reviewed changes
@swadeley swadeley force-pushed the swadeley/code_coverage_log_to_currents branch 2 times, most recently from 6b87ed5 to f2280c9 Compare February 5, 2026 05:06
@swadeley swadeley mentioned this pull request Feb 5, 2026
Merged
@swadeley swadeley force-pushed the swadeley/code_coverage_log_to_currents branch from f2280c9 to 5bfb5a6 Compare February 5, 2026 06:05
@swadeley
Copy link
Member Author

swadeley commented Feb 5, 2026

@sourcery-ai review

sourcery-ai[bot]

This comment was marked as outdated.

Sign in to view

@swadeley swadeley marked this pull request as draft February 5, 2026 07:43
@swadeley
Copy link
Member Author

swadeley commented Feb 5, 2026

@sourcery-ai dismiss

@swadeley swadeley force-pushed the swadeley/code_coverage_log_to_currents branch from 5bfb5a6 to 3d07e3a Compare February 5, 2026 07:51
@swadeley
Copy link
Member Author

swadeley commented Feb 5, 2026

@sourcery-ai review

sourcery-ai[bot]

This comment was marked as outdated.

Sign in to view

@swadeley swadeley force-pushed the swadeley/code_coverage_log_to_currents branch 2 times, most recently from 08ee1a4 to 97ceeb8 Compare February 6, 2026 04:32
@swadeley swadeley force-pushed the swadeley/code_coverage_log_to_currents branch from 97ceeb8 to e328098 Compare February 6, 2026 05:49
@swadeley swadeley mentioned this pull request Feb 6, 2026
Open
@swadeley swadeley force-pushed the swadeley/code_coverage_log_to_currents branch from 8ec1b4c to c919dbe Compare February 6, 2026 11:08
@swadeley
Copy link
Member Author

swadeley commented Feb 6, 2026

@sourcery-ai dismiss

@swadeley
Copy link
Member Author

swadeley commented Feb 6, 2026

@sourcery-ai review

sourcery-ai[bot]

This comment was marked as outdated.

Sign in to view

@swadeley swadeley force-pushed the swadeley/code_coverage_log_to_currents branch from c919dbe to 2e3d20a Compare February 6, 2026 12:45
@swadeley
Copy link
Member Author

swadeley commented Feb 6, 2026

@sourcery-ai dismiss

@swadeley
Copy link
Member Author

swadeley commented Feb 6, 2026

@sourcery-ai review

sourcery-ai[bot]

This comment was marked as outdated.

Sign in to view

@swadeley swadeley force-pushed the swadeley/code_coverage_log_to_currents branch from 2e3d20a to 2ca0941 Compare February 6, 2026 13:04
@swadeley
Copy link
Member Author

swadeley commented Feb 6, 2026

@sourcery-ai dismiss

@swadeley
Copy link
Member Author

swadeley commented Feb 6, 2026

@sourcery-ai review

sourcery-ai[bot]
sourcery-ai bot reviewed Feb 6, 2026
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@swadeley swadeley marked this pull request as ready for review February 6, 2026 14:01
@swadeley swadeley mentioned this pull request Feb 10, 2026
Draft
@swadeley
Bump submodules
ef618ad 
 Import fixtures for coverage upload to Currents
@swadeley
Import from test-utils not pw test
cd4540b 
All tests should import this way.
@swadeley
Export code coverage reports to currents.dev
78ba166
@swadeley swadeley force-pushed the swadeley/code_coverage_log_to_currents branch from 0ebd50a to 78ba166 Compare February 10, 2026 12:20
dominikvagner
dominikvagner reviewed Feb 12, 2026
View reviewed changes
Copy link
Member

@dominikvagner dominikvagner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good now, but there seems to be some issue with the GHA for playwright tests 🔍 [log]
it's missing quite a lot of info, seems to output test logs in a different format and currents seems like it can't connect 👀

@swadeley
Copy link
Member Author

swadeley commented Feb 12, 2026 •
edited
Loading

Hi @dominikvagner

The GitHub Actions do not work properly with a PR from a fork, so I made another PR direct on the repo for testing:
#861

I can close this and take that one out of draft status if you prefer.

Sorry for the confusion.

@dominikvagner
Copy link
Member

dominikvagner commented Feb 12, 2026

Hi @dominikvagner

The GitHub Actions do not work properly with a PR from a fork, so I made another PR direct on the repo for testing: #861

I can close this and take that one out of draft status if you prefer.

Sorry for the confusion.

ahh, wondered why there is that one 😅 I think it'd be better to just focus on the one that works, so let's close this and open (take out of draft) the other if you don't mind 👍🏼

and also that issue with the logs is present even in the other one 👀

@swadeley swadeley closed this Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dominikvagner dominikvagner dominikvagner requested changes

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

@dominikvagner dominikvagner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swadeley @dominikvagner