Build: generate deployment.yaml from template#1157
Draft
jlsherrill wants to merge 1 commit intocontent-services:mainfrom
Draft
Build: generate deployment.yaml from template#1157jlsherrill wants to merge 1 commit intocontent-services:mainfrom
jlsherrill wants to merge 1 commit intocontent-services:mainfrom
Conversation
rverdile
reviewed
Jul 28, 2025
Contributor
rverdile
left a comment
rverdile
left a comment
There was a problem hiding this comment.
I haven't tested it, but I like the idea. I say let's do it.
jlsherrill
commented
Jul 30, 2025
| valueFrom: | ||
| secretKeyRef: | ||
| name: content-sources-sentry | ||
| name: content-sources-glitchtip |
Member
Author
There was a problem hiding this comment.
apparently content-sources-sentry was removed a long time ago in favor of content-sources-glitchtip and a few of these were not updated
Contributor
|
+1 to this idea! i did a small test to generate the deployment with a new common env var and noticed that it wasn't added to the parameters section, that's something we'll probably want to add. maybe automate it if possible or a validation step to check that every env var has a matching parameter definition? |
Contributor
|
more evidence for the usefulness of this: #1326 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creates some a method for generating the deployment.yaml file from a template and a yaml file with variables. Generally all variables are used for all items, except for the transform-pulp-logs which needs very specific special secrets.
Testing steps
Initially i'm looking for general feedback for the approach, not necessarily a full review at this time.
Largely created by cursor.