Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grouping by week (replaces #533) #616

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Add grouping by week (replaces #533) #616

merged 2 commits into from
Nov 18, 2023

Conversation

cliffparnitzky
Copy link
Contributor

@cliffparnitzky cliffparnitzky commented Nov 16, 2023 •
edited
Loading

Implements the backend grouping by week

Description

screen

replaces #533

Checklist

  • Read and understood the CONTRIBUTING guidelines
  • Created tests, if possible
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself to the @authors in touched PHP files
  • Checked the changes with phpcq and introduced no new issues

@cliffparnitzky
Add grouping by week (replaces #533)
80d7769 
Implements the backend grouping by week
@cliffparnitzky cliffparnitzky mentioned this pull request Nov 16, 2023
Closed
6 tasks
@zonky2 zonky2 requested a review from discordier November 17, 2023 07:45
@zonky2 zonky2 added this to the 2.3.2 milestone Nov 17, 2023
@zonky2 zonky2 self-requested a review November 17, 2023 08:04
zonky2
zonky2 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@zonky2 zonky2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

discordier
discordier approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@discordier discordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanheimes stefanheimes merged commit a4baf60 into contao-community-alliance:master Nov 18, 2023
2 checks passed
@cliffparnitzky cliffparnitzky deleted the grouping_by_week branch November 18, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zonky2 zonky2 zonky2 approved these changes

@discordier discordier discordier approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@cliffparnitzky @discordier @zonky2 @stefanheimes