Merge tag '2.3.28'

Hotfix release 2.3.28

- Fix deepcopy issues
- Fix move item if clipboard not empty

src/Contao/Event/Subscriber.php

@@ -327,7 +327,7 @@ public function initializePanels(ActionEvent $event): void
         if (
             !\in_array(
                 $event->getAction()->getName(),
-                ['copy', 'create', 'paste', 'delete', 'move', 'undo', 'edit', 'toggle', 'showAll', 'show'],
+                ['copy', 'deepcopy', 'create', 'paste', 'delete', 'move', 'undo', 'edit', 'toggle', 'showAll', 'show'],
                 true
             )
         ) {

src/Contao/View/Contao2BackendView/ActionHandler/CopyHandler.php

@@ -127,7 +127,7 @@ public function handleEvent(ActionEvent $event)
             return;
         }
 
-        if ('copy' !== $event->getAction()->getName()) {
+        if (!\in_array($event->getAction()->getName(), ['copy', 'deepcopy'])) {
             return;
         }
 

src/Contao/View/Contao2BackendView/ActionHandler/PasteHandler.php

@@ -113,8 +113,10 @@ protected function process(EnvironmentInterface $environment)
         assert(\is_string($providerName));
 
         // Check if it is a simple create-paste of a single model, if so, redirect to edit view.
+        // Only for not ajax calls e.g. move.
         if (
-            $this->isSimpleCreatePaste(
+            null === $input->getParameter('isAjax')
+            && $this->isSimpleCreatePaste(
                 $clipboard,
                 $providerName
             )

src/Contao/View/Contao2BackendView/ActionHandler/SelectHandler.php

@@ -395,7 +395,7 @@ private function handleCopyAllAction(EnvironmentInterface $environment, Action $
             $inputProvider->unsetParameter('source');
         }
 
-        ViewHelpers::redirectHome($environment);
+        ViewHelpers::redirectCleanHome($environment, ['select']);
     }
 
     /**

src/Contao/View/Contao2BackendView/ButtonRenderer.php

@@ -460,13 +460,15 @@ private function getChildIds(ModelInterface $model): array
     private function calculateParameters(CommandInterface $command, string $serializedModelId): array
     {
         $parameters = (array) $command->getParameters();
+
         if ($command instanceof ToggleCommandInterface) {
             // Toggle has to trigger the javascript.
             $parameters['act'] = $command->getName();
             $parameters['id']  = $serializedModelId;
 
             return $parameters;
         }
+
         if (($command instanceof CutCommandInterface) || ($command instanceof CopyCommandInterface)) {
             // Cut & copy need some special information.
             if (!\array_key_exists('act', $parameters)) {

src/Contao/View/Contao2BackendView/Controller/ClipboardController.php

@@ -301,15 +301,18 @@ private function addToClipboard(ActionEvent $event)
             $this->removeItemsFromClipboard($event);
 
             // Only push item to clipboard if manual sorting is used.
-            if (Item::COPY === $clipboardActionName && null === ViewHelpers::getManualSortingProperty($environment)) {
+            if (
+                \in_array($clipboardActionName, [Item::COPY, Item::DEEP_COPY])
+                && null === ViewHelpers::getManualSortingProperty($environment)
+            ) {
                 return;
             }
 
             // create the new item
             $item = new Item($clipboardActionName, $parentId, $modelId);
         }
 
-        // If edit several don´t redirect do home and push item to the clipboard.
+        // If edit several don´t redirect to home and push item to the clipboard.
         if ('select' === $input->getParameter('act')) {
             $clipboard->push($item)->saveTo($environment);
 
@@ -319,7 +322,7 @@ private function addToClipboard(ActionEvent $event)
         // Let the clipboard save it's values persistent.
         $clipboard->clear()->push($item)->saveTo($environment);
 
-        ViewHelpers::redirectHome($environment);
+        ViewHelpers::redirectCleanHome($environment, ['select']);
     }
 
     /**

src/Contao/View/Contao2BackendView/ViewHelpers.php

@@ -113,6 +113,7 @@ public static function getManualSortingProperty(EnvironmentInterface $environmen
             $sort = $panel->getElement('sort');
             if ($sort instanceof SortElementInterface) {
                 $definition = $sort->getSelectedDefinition();
+                break;
             }
         }