[wip] integration: do not pull from Docker Hub

[runcom]

• Fix WIP: integration: do not pull from Docker Hub #132
• Requires docker: add docker-archive transport image#148
• Cleanup the Dockerfile by removing registry V1 since we don't support it at all

When containers/image#148 is merged - we'll load images on the test registries when the test suites come up.

@mtrmac PTAL

Signed-off-by: Antonio Murdaca [email protected]

[runcom]

we'll likely remove this as well once we have docker-archive transport and directly use skopeo probably

[cyphar]

We've now had docker-archive for a while, so we can drop this. 😉

[mtrmac]

This doesn’t actually remove any Hub references from the tests yet, does it?

[runcom]

This doesn’t actually remove any Hub references from the tests yet, does it?

not yet, waiting on the docker-archive functionality at least

[mtrmac]

If I understand correctly, the idea is to use that shell script → docker-archive: → docker load → docker push to recreate the needed images in our registry; is that right?

If so, why not just do docker pull && docker push, perhaps both in the Dockerfile?

[runcom]

@mtrmac we don't have docker in the docker container - and I wouldn't have it also.
The idea is to download the images in the Dockerfile, and at test suite setup skopeo copy ... from tarballs directly:

skopeo copy docker-archive:/localimage.tar docker://testregistry.com:5000/busybox:latest

[mtrmac]

Oops, that was stupid of me.

In that case, we could also use dir: instead of docker-archive:, that involves fewer manifest conversions. OTOH the conversions, both in the new script and in docker-archive:, are already implemented, so reworking the script to use the dir: format would be quite unnecessary work.

[cyphar]

👍 However we have to make sure that that docker:// source is properly tested with the live Docker Hub. Maybe make it a separate suite or something -- but we still need to verify that the upstream Docker Hub still works with us.

[runcom]

However we have to make sure that that docker:// source is properly tested with the live Docker Hub. Maybe make it a separate suite or something -- but we still need to verify that the upstream Docker Hub still works with us.

of course, yes

[rhatdan]

Is this pull request still something we are considering?

[rhatdan]

@runcom Either update this or close it.