Skip to content

rename "nopull" boolean to "pull" #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhatdan merged 1 commit into from
Jun 26, 2025
Merged

rename "nopull" boolean to "pull" #1611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ramalama/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def configure_arguments(parser):
)
parser.add_argument(
"--image",
default=accel_image(CONFIG, nopull=True),
default=accel_image(CONFIG, pull=False),
help="OCI container image to run with the specified AI model",
action=OverrideDefaultAction,
completer=local_images,
Expand Down
4 changes: 2 additions & 2 deletions ramalama/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ class AccelImageArgsOtherRuntimeRAG(Protocol):
AccelImageArgs = None | AccelImageArgsVLLMRuntime | AccelImageArgsOtherRuntime | AccelImageArgsOtherRuntimeRAG


def accel_image(config: Config, nopull=False) -> str:
def accel_image(config: Config, pull=True) -> str:
"""
Selects and the appropriate image based on config, arguments, environment.
"""
Expand All @@ -650,7 +650,7 @@ def accel_image(config: Config, nopull=False) -> str:
return "registry.redhat.io/rhelai1/ramalama-vllm"

vers = minor_release()
if nopull or attempt_to_use_versioned(config.engine, image, vers, True):
if not pull or attempt_to_use_versioned(config.engine, image, vers, True):
return f"{image}:{vers}"

return f"{image}:latest"
Expand Down
Loading