Skip to content

Conversation

@wking
Copy link
Contributor

@wking wking commented May 19, 2018

I'd accidentally introduced these typos in #772.

I'd accidentally introduced these typos in ea41561 (hooks/docs: Add
oci-hooks.5 and per-package man page building, 2018-05-15, containers#772).

Signed-off-by: W. Trevor King <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented May 20, 2018

bot, retest this please

@wking
Copy link
Contributor Author

wking commented May 20, 2018

I'm not sure how Markdown fixes are leading to:

Error determining manifest MIME type for docker://busybox:latest
...
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x1f0 pc=0xa0fb0c]

goroutine 128 [running]:
testing.tRunner.func1(0xc4205002d0)
	/usr/lib/golang/src/testing/testing.go:742 +0x29d
panic(0xad1180, 0x116f030)
	/usr/lib/golang/src/runtime/panic.go:502 +0x229
github.com/projectatomic/libpod/libpod/image.(*Image).ID(...)
	/go/src/github.com/projectatomic/libpod/libpod/image/image.go:257
github.com/projectatomic/libpod/libpod/image.TestImage_New(0xc4205002d0)
	/go/src/github.com/projectatomic/libpod/libpod/image/image_test.go:132 +0x38c
testing.tRunner(0xc4205002d0, 0xbd0358)
	/usr/lib/golang/src/testing/testing.go:777 +0xd0
created by testing.(*T).Run
	/usr/lib/golang/src/testing/testing.go:824 +0x2e0
FAIL	github.com/projectatomic/libpod/libpod/image	25.636s

That seems like a pretty major flake.

@rhatdan
Copy link
Member

rhatdan commented May 20, 2018

@baude PTAL, It looks like there is a way to get an Image struct without a valid image field. If this is ok to happen then those return calls should be checking if i.image has been set and if not return "".

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, can't imagine they're causing test hiccups.

@mheon
Copy link
Member

mheon commented May 20, 2018

Probably a network flake in the image library unit tests. Those tests are not particularly durable, and will segfault fairly consistently if they fail to pull an image down. Should probably look into adding fault tolerance to them at some point.

@mheon
Copy link
Member

mheon commented May 21, 2018

bot, retest this please

@mheon
Copy link
Member

mheon commented May 21, 2018

LGTM once tests are green.

@mheon
Copy link
Member

mheon commented May 21, 2018

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit a8e544c has been approved by mheon

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit a8e544c with merge 31e3a50...

@rh-atomic-bot
Copy link
Collaborator

☀️ Test successful - status-papr
Approved by: mheon
Pushing 31e3a50 to master...

@wking wking deleted the hooks-markdown-fixups branch May 21, 2018 16:35
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants