-
Notifications
You must be signed in to change notification settings - Fork 2.9k
hooks/README: Fix some Markdown typos (e.g. missing runc target) #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'd accidentally introduced these typos in ea41561 (hooks/docs: Add oci-hooks.5 and per-package man page building, 2018-05-15, containers#772). Signed-off-by: W. Trevor King <[email protected]>
|
bot, retest this please |
|
I'm not sure how Markdown fixes are leading to:
That seems like a pretty major flake. |
|
@baude PTAL, It looks like there is a way to get an Image struct without a valid image field. If this is ok to happen then those return calls should be checking if i.image has been set and if not return "". |
TomSweeneyRedHat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, can't imagine they're causing test hiccups.
|
Probably a network flake in the image library unit tests. Those tests are not particularly durable, and will segfault fairly consistently if they fail to pull an image down. Should probably look into adding fault tolerance to them at some point. |
|
bot, retest this please |
|
LGTM once tests are green. |
|
📌 Commit a8e544c has been approved by |
|
☀️ Test successful - status-papr |
I'd accidentally introduced these typos in #772.