-
Notifications
You must be signed in to change notification settings - Fork 2.9k
test: Fix --hostuser octal UID test flakiness #27813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
Honny1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
|
LGTM |
1 similar comment
|
LGTM |
mtrmac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall principle LGTM.
0ed32eb to
253a440
Compare
The test for issue containers#19800 depended on finding a system user with an octal UID. This approach was fragile because system users found on the host may have a different UID in the testing image. Use the rootless user ID instead which is likely to be octal anyway as new user IDs start with 1000. Signed-off-by: Ricardo Branco <[email protected]>
253a440 to
174e02a
Compare
mtrmac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
|
/approved |
baude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The test for issue #19800 depended on finding a system user with an octal UID. This approach was fragile because system users found on the host may have a different UID in the testing image.
Use the rootless user ID instead which is likely to be octal anyway as new user IDs start with 1000.
Related failure:
https://openqa-assets.opensuse.org/tests/5535030/file/podman-bats-user-local.tap.txt
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?