Switch common, storage and image to monorepo. #26858
Conversation
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
you need to replace all import paths in the repo with the new ones and run make vendor for the new paths to work, so yeah you need something like |
openshift-merge-robot
added
the
needs-rebase
github-actions
bot
added
machine
kind/api-change
jankaluza
force-pushed
the
monorepo
branch
8 times, most recently
from
02ffbf1 to
050c638
Compare
jankaluza
changed the title
openshift-merge-robot
removed
the
needs-rebase
Signed-off-by: Jan Kaluza <[email protected]>
| github.com/containerd/stargz-snapshotter/estargz v0.17.0 // indirect | ||
| github.com/containerd/typeurl/v2 v2.2.3 // indirect | ||
| github.com/containernetworking/cni v1.3.0 // indirect | ||
| github.com/containers/common v0.62.2 // indirect |
There was a problem hiding this comment.
That does not seem right we still depend on the old repo!
There was a problem hiding this comment.
Yes, this is caused by the crc-org/crc ecosystem. I'm preparing PRs for them, but I think this will take some time for them to review and merge. I was wondering if we can merge this PR and update to newer crc once they are done with their part.
There was a problem hiding this comment.
crc-org/crc#4902, but more will follow. There are more packages which depend on containers/common there directly.
There was a problem hiding this comment.
It seems to compile find so I guess it works and it is only the one package pkg/strongunits which is not to bad.
I dislike it but I dislike not getting this merged soon more but this is 100% something that we must fix before the 5.7 release.
There was a problem hiding this comment.
Yeah. I wanted to explain this once the tests are green, but you have asked faster than that :-).
I share the same opinion - it is just a single import and I believe it should work fine. I will actively monitor the crc PRs and will bump the crc in our go.mod to remove the dependency asap.
openshift-ci
bot
added
the
approved
|
@containers/podman-maintainers PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, jankaluza, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Luap99
added
release-note-none
and removed
do-not-merge/release-note-label-needed
openshift-merge-bot
bot
merged commit 39072f7
into
containers:main
4 participants
Does this PR introduce a user-facing change?