-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Vendorruntimetools #1007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendorruntimetools #1007
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,10 @@ const cpuPeriod = 100000 | |
| // CreateConfigToOCISpec parses information needed to create a container into an OCI runtime spec | ||
| func CreateConfigToOCISpec(config *CreateConfig) (*spec.Spec, error) { //nolint | ||
| cgroupPerm := "ro" | ||
| g := generate.New() | ||
| g, err := generate.New("linux") | ||
|
||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| g.HostSpecific = true | ||
| addCgroup := true | ||
| if config.Privileged { | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have
g.Spec()->g.Config(and similarly inCreateConfigToOCISpec).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've filed #1008 for this.