feat(playground): mcp servers listed #3065
Conversation
packages/backend/src/studio.ts
Outdated
| @@ -213,6 +213,7 @@ export class Studio { | |||
| */ | |||
| this.#catalogManager = new CatalogManager(this.#rpcExtension, appUserDirectory); | |||
| this.#catalogManager.init(); | |||
| this.#extensionContext.subscriptions.push(this.#catalogManager); | |||
There was a problem hiding this comment.
This was missing, it's my understanding that it should be pushed to the subscriptions for disposal.
There was a problem hiding this comment.
It is now optional as every Disposable it automatically disposed when extension is stopped. Should be moved to a separate PR
There was a problem hiding this comment.
I've removed my additions of what I considered to be missing entries.
However, I'm having a hard time understanding how are the Disposables discovered by the extension for automatic disposal.
There was a problem hiding this comment.
Yeah, for extension-defined disposable, it should be disposed by the extension. The disposable provided by the extension-api are disposed by the core, but I think it is always a good idea to do it, for good practice.
packages/backend/src/studio.ts
Outdated
| @@ -385,6 +386,7 @@ export class Studio { | |||
| */ | |||
| this.#snippetManager = new SnippetManager(this.#rpcExtension, this.#telemetry); | |||
| this.#snippetManager.init(); | |||
| this.#extensionContext.subscriptions.push(this.#snippetManager); | |||
There was a problem hiding this comment.
This was missing, it's my understanding that it should be pushed to the subscriptions for disposal.
Signed-off-by: Marc Nuri <[email protected]>
manusa
force-pushed
the
feat/mcp-servers-playground-ui
branch
from
c92bbfd to
b240506
Compare
|
Works as described, only similar thing that comes to my mind is changing contexts:
|
|
For additional reference, this is how a similar UI looks like in VSCode:
I tried to use the DropDown component first, but (besides some issues with the parent component's overflow-y:auto) it seemed incompatible with what we're aiming for here. |
Signed-off-by: Marc Nuri <[email protected]>
What does this PR do?
Adds a UI element to be able to (later) activate/deactivate MCP Servers and their specific tools (even later).
This is the first iteration just to validate that the UI is aligned with the current expectation.
The next immediate iteration would be to add functionality to the checkboxes of the servers.
With this regard it would be good to know what effect we want for them.
For example, do we want them to be mapped to the file entries and update them there?
Screenshot / video of UI
podman-desktop-ai-lab-mcp-servers-ui.mp4
What issues does this PR fix or reference?
Part of #2885
How to test this PR?
~/.local/share/containers/podman-desktop/extensions-storage/redhat.ai-lab/mcp-settings.json.{ "servers": { "time": { "enabled": true, "type": "stdio", "command": "podman", "args": ["run", "-i", "--rm", "docker.io/mcp/time"] } } }MCP Serversshould be visible in the Settings pane.