-
Notifications
You must be signed in to change notification settings - Fork 59
chore(test): function calling test #3046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test(`Verify that model service for the ${appName} is working`, async ({ request }) => { | ||
test.setTimeout(600_000); | ||
const modelServicePage = await aiLabPage.navigationBar.openServices(); | ||
const serviceDetailsPage = await modelServicePage.openSercviceDetails( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openSercviceDetails => openServiceDetails ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beforeAll and afterAll hooks do not seem to match what is required.
790ab87
to
a866743
Compare
Signed-off-by: Anton Misskii <[email protected]>
b69d72a
to
b69c7e5
Compare
if (serviceRow === undefined) { | ||
throw new Error(`Model [${modelName}] service doesn't exist`); | ||
} | ||
const serviceRowName = serviceRow.getByRole('cell').nth(3); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please open follow up issue to address missing aria-labels in the row definition. We should not rely on order of the cells. This is out of scope of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What does this PR do?
Adds Function Calling Demo AI App to installation and verification list
Implements custom interaction with the AI App service
What issues does this PR fix or reference?
#2563
How to test this PR?