Skip to content

chore(test): function calling test #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

amisskii
Copy link
Contributor

What does this PR do?

Adds Function Calling Demo AI App to installation and verification list
Implements custom interaction with the AI App service

What issues does this PR fix or reference?

#2563

How to test this PR?

@amisskii amisskii requested review from benoitf, jeffmaury and a team as code owners May 20, 2025 10:37
@amisskii amisskii requested review from dgolovin and SoniaSandler May 20, 2025 10:37
test(`Verify that model service for the ${appName} is working`, async ({ request }) => {
test.setTimeout(600_000);
const modelServicePage = await aiLabPage.navigationBar.openServices();
const serviceDetailsPage = await modelServicePage.openSercviceDetails(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openSercviceDetails => openServiceDetails ?

Copy link
Contributor

@cbr7 cbr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments above.

Copy link
Contributor

@cbr7 cbr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beforeAll and afterAll hooks do not seem to match what is required.

@amisskii amisskii requested a review from cbr7 May 22, 2025 10:58
@amisskii amisskii force-pushed the function-calling-app branch from 790ab87 to a866743 Compare May 22, 2025 11:01
@amisskii amisskii force-pushed the function-calling-app branch from b69d72a to b69c7e5 Compare May 27, 2025 07:15
if (serviceRow === undefined) {
throw new Error(`Model [${modelName}] service doesn't exist`);
}
const serviceRowName = serviceRow.getByRole('cell').nth(3);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open follow up issue to address missing aria-labels in the row definition. We should not rely on order of the cells. This is out of scope of this PR.

Copy link
Contributor

@odockal odockal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@amisskii amisskii merged commit 4366a09 into containers:main May 27, 2025
7 checks passed
@amisskii amisskii linked an issue May 27, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Function Calling Demo AI App installation test and interaction
4 participants