Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support copy multi arch instance #2612

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

support copy multi arch instance #2612

wants to merge 1 commit into from

Conversation

cleverhu
Copy link

support copy multi arch instance

@cleverhu cleverhu mentioned this pull request Oct 28, 2024
Open
mtrmac
mtrmac reviewed Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

For now just a quick skim. Primarily note that we must not break API.

Note the existence of previous #1707 , #1938 , those probably discuss relevant concerns. I didn’t now go back to re-visit either of them.

copy/multiple.go Outdated Show resolved Hide resolved
copy/multiple.go Outdated Show resolved Hide resolved
copy/multiple.go Outdated Show resolved Hide resolved
copy/multiple.go Show resolved Hide resolved
copy/multiple.go Show resolved Hide resolved
copy/multiple.go Outdated Show resolved Hide resolved
copy/multiple.go Outdated Show resolved Hide resolved
internal/manifest/docker_schema2_list.go Outdated Show resolved Hide resolved
internal/manifest/oci_index.go Outdated Show resolved Hide resolved
copy/multiple.go Outdated Show resolved Hide resolved
@mtrmac mtrmac added the kind/feature A request for, or a PR adding, new functionality label Oct 29, 2024
@cleverhu
Copy link
Author

@mtrmac I'm sorry for the delay in updating due to work reasons. Could you please review my optimized code now? I have added a copy type parameter called CopyCustomArchImages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrmac mtrmac mtrmac left review comments

Assignees
No one assigned
Labels
kind/feature A request for, or a PR adding, new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cleverhu @mtrmac