Canonicalize docker references in signature.VerifyDockerManifestSignature #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
…ture After containers#220, and especially future containers#221, signing docker/distribution/reference.Named.String() would use the new fully-expanded normalization (as opposed to containers/image/docker/reference.Named.String(), which is minimized). For interoperability between various versions and signers, parse and normalize the expected and signed references before comparing them. This should be equivalent to prmMatchExact.matchesDockerReference(). Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
force-pushed
the
canonicalize-VerifyDockerManifestSignature
branch
from
0a4e6b6 to
73dfbc6
Compare
Collaborator
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #220, and especially future #221, signing
docker/distribution/reference.Named.String()would use the new fully-expanded normalization (as opposed tocontainers/image/docker/reference.Named.String(), which is minimized).For interoperability between various versions and signers, parse and normalize the expected and signed references before comparing them.
This should be equivalent to
prmMatchExact.matchesDockerReference().It is also fairly tempting to use a
reference.Namedinstead of astringas the parameters to the public functions indocker.go; however, theNamedinterface does not really guarantee what kind of canonicalization is used. (Right now, due to the extra methods incontainers/image/docker/reference.Named, it is impossible to substitute an upstreamdocker/distribution/reference.Namedimplementation, but #221 would again make that untrue.) For now I have leaned towards not changing things.