Move define.TempDirForURL() to pkg/tmpdir.ForURL(), unify its and Add()'s http client configurations #6441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
@nalind, did you intend to use the name |
Member
Author
|
Yeah, it's used by |
nalind
force-pushed
the
temp-dir-for-url-pkg
branch
from
462f4f3 to
20c9435
Compare
Member
Author
|
Moved those bits to a new |
nalind
force-pushed
the
temp-dir-for-url-pkg
branch
from
20c9435 to
dedabe6
Compare
Member
Author
|
Tweaked a bit to expose the proxy setting directly for callers. |
Move the generic "download a thing" function to a package that wasn't originally intended to only include type definitions, but leave a wrapper in the old location for compatibility's sake. Signed-off-by: Nalin Dahyabhai <[email protected]>
Make sure that tmpdir.ForURL() and Add() use the same HTTP client configurations, both for TLS and proxies, so that we apply the same settings when fetching build contexts that we do for ADD instructions. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
temp-dir-for-url-pkg
branch
from
dedabe6 to
dd78138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The HTTP client configurations used by Add() and the logic that we use for pulling down build contexts that are specified using URLs differ in their setup, and the latter doesn't implement the --tls-verify=false flag.
How to verify it
New integration test!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
This is also a follow-up to #6274.
This moves the function that we use for retrieving things and putting them into temporary directories into its own package, but leaves behind an API-compatible wrapper function.
Does this PR introduce a user-facing change?