-
Notifications
You must be signed in to change notification settings - Fork 855
feat: support --mount=type=secret,id=foo,env=bar #6285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: support --mount=type=secret,id=foo,env=bar #6285
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aeijdenberg The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ca6c7f0 to
e42de5f
Compare
e42de5f to
bbfa364
Compare
|
Hi Team! |
bbfa364 to
3a2513c
Compare
|
Rebased on latest main to fix merge conflict in test. |
|
A friendly reminder that this PR had no activity for 30 days. |
|
Hi there, has there been any progress in the status of this PR? Not having docker-like |
3a2513c to
701d376
Compare
|
Rebased to fix merge conflict. |
701d376 to
95f2336
Compare
Allow secrets specified with mount to result in env variable set as an alternative to mounting a file. This matches Docker behaviour: https://docs.docker.com/reference/dockerfile/#example-mount-as-environment-variable Signed-off-by: Adam Eijdenberg <[email protected]>
95f2336 to
ff08a60
Compare
|
Rebased to fix merge conflict. |
Allow secrets specified with mount to result in env variable set as an alternative to mounting a file.
This matches Docker behaviour:
https://docs.docker.com/reference/dockerfile/#example-mount-as-environment-variable
What type of PR is this?
/kind feature
What this PR does / why we need it:
Docker supports making secret mounts appear as environment variables during a
RUNcommand. This adds the same tobuildah.See: https://docs.docker.com/reference/dockerfile/#example-mount-as-environment-variable
How to verify it
bats test added.
Which issue(s) this PR fixes:
Fixes #5892
Special notes for your reviewer:
Does this PR introduce a user-facing change?