Skip to content

Conversation

@boaz0
Copy link
Collaborator

@boaz0 boaz0 commented Jan 16, 2018

A follow-up to #385 and containers/image#390.

@rh-atomic-bot
Copy link
Collaborator

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@rhatdan
Copy link
Member

rhatdan commented Jan 16, 2018

bot, add author to whitelist

@rhatdan
Copy link
Member

rhatdan commented Jan 16, 2018

LGTM

@nalind
Copy link
Member

nalind commented Jan 16, 2018

LGTM. @giuseppe, this should also fix #390, right?

@rhatdan
Copy link
Member

rhatdan commented Jan 16, 2018

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit 7c66765 has been approved by rhatdan

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit 7c66765 with merge 4d6c90e...

@rh-atomic-bot
Copy link
Collaborator

☀️ Test successful - status-papr
Approved by: rhatdan
Pushing 4d6c90e to master...

@boaz0 boaz0 deleted the vendor_containers_image branch January 16, 2018 17:53
@giuseppe
Copy link
Member

@nalind yes correct. It should fix #390

nalind pushed a commit that referenced this pull request Apr 2, 2018
When creating container storage by name, if that name is a tagged image then the storage
could not be found.  We now use the image id which seems more reliable. Also added an
integration test to protect against regression.

Signed-off-by: baude <[email protected]>

Closes: #393
Approved by: mheon
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants