-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
continue prost #286
base: master
Are you sure you want to change the base?
continue prost #286
Conversation
@jokemanfire I appreciate you taking on this work very much. Thanks agian. |
There are some conflicts and API changes that need to be resolved and some code needs to be packaged to adapt to the current API. It's not easy to operate with the previous version of PR. I need to add some commit to complete this feature. I have communicated with the original author. |
dcf4304
to
781c816
Compare
@Tim-Zhang @justxuewei Local test all pass but i don't know how to install protoc in CI. |
21ebbd3
to
4a76b7b
Compare
a29312f
to
5fadae0
Compare
Basically enough @Tim-Zhang @justxuewei just take a look . :) |
Nice work, thanks @jokemanfire! Could you cleanup your commits? It makes us easier to review and maintain.
Thanks! |
This commit refactors the ttrpc-codegen and the compiler, and merges the two crates into a single crate, named "codegen". The codegen uses prost crate, a protobuf compiler for Rust. Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
The ttrpc provides a "prost" feature to support the new version of codegen. An "example2" has been added to demonstrate how to use the codegen. Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
Install protoc when executing `make deps` of the ttrpc. Add codegen's check and build, and example2' build to the ci testing. Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
Fix all issues reported by cargo clippy to make ci testing pass. Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
merge from remote branch. ref: containerd#173 Co-authored-by: Xuewei Niu <niuxuewei.nxw@antgroup.com> Signed-off-by: jokemanfire <hu.dingyang@zte.com.cn>
fix ci for protoc Signed-off-by: jokemanfire <hu.dingyang@zte.com.cn>
because of the api change 1. fix the marco in prost 2. fix the test Signed-off-by: jokemanfire <hu.dingyang@zte.com.cn>
fix rebase error. Signed-off-by: jokemanfire <hu.dingyang@zte.com.cn>
I have changed it. |
aa000cc
to
4da8148
Compare
b25b1a0
to
00fce61
Compare
skip build example2 in windows Signed-off-by: jokemanfire <hu.dingyang@zte.com.cn>
Once this feature gets merged, I prefer to bump a major version to 2 to avoid some compatibility issues, as it nearly changes the entire codegen engine. WDYT? @jokemanfire @Tim-Zhang |
This modification is indeed quite significant, and I agree. It depends on the maintainer's thoughts |
work continue with #173