Skip to content

Conversation

@thaJeztah
Copy link
Member

relates to opencontainers/runc#3353

runc option --criu is now ignored (with a warning), and the option will be
removed entirely in a future release. Users who need a non- standard criu
binary should rely on the standard way of looking up binaries in $PATH.

@codecov-commenter
Copy link

Codecov Report

Merging #82 (d539c33) into main (1c99ade) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   21.45%   21.52%   +0.06%     
==========================================
  Files           7        7              
  Lines         685      683       -2     
==========================================
  Hits          147      147              
+ Misses        500      499       -1     
+ Partials       38       37       -1     
Impacted Files Coverage Δ
runc.go 21.18% <ø> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c99ade...d539c33. Read the comment docs.

runc option --criu is now ignored (with a warning), and the option will be
removed entirely in a future release. Users who need a non- standard criu
binary should rely on the standard way of looking up binaries in $PATH.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael crosbymichael merged commit 4995779 into containerd:main Jan 31, 2022
@thaJeztah thaJeztah deleted the deprecate_criu_opt branch January 31, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants