Skip to content

Hermeto: default config#2177

Merged
MartinBasti merged 1 commit intocontainerbuildsystem:masterfrom
MartinBasti:hermeto-default-config
May 21, 2025
Merged

Hermeto: default config#2177
MartinBasti merged 1 commit intocontainerbuildsystem:masterfrom
MartinBasti:hermeto-default-config

Conversation

@MartinBasti
Copy link
Contributor

Provide default config to keep compatibility with OSBS/Cachito workflows as much as possible

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Python type annotations added to new code
  • JSON/YAML configuration changes are updated in the relevant schema
  • Changes to metadata also update the documentation for the metadata
  • Pull request has a link to an osbs-docs PR for user documentation updates
  • New feature can be disabled from a configuration file

Provide default config to keep compatibility with OSBS/Cachito workflows
as much as possible

Signed-off-by: Martin Basti <[email protected]>
Copy link
Contributor

@taylormadore taylormadore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Hermeto config LGTM

@MartinBasti MartinBasti force-pushed the hermeto-default-config branch from 7b20e8d to 03dcd60 Compare May 21, 2025 14:36
@MartinBasti MartinBasti merged commit 068f01f into containerbuildsystem:master May 21, 2025
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments