Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade default version of kind and kubectl #11

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Upgrade default version of kind and kubectl #11

merged 2 commits into from
Feb 9, 2023

Conversation

essobedo
Copy link
Contributor

@essobedo essobedo commented Feb 8, 2023

fixes tests broken by #10

Motivation

Many tests are failing on MacOS because they test against very old versions of kind that don't work properly on MacOS, thus we can benefit from this problem to upgrade the default version of kind to a more recent version.

Modifications

  • Upgrade the default version of kind to v0.17.0
  • Upgrade the default version of kubectl to v1.26.1
  • Test against the latest versions of kind, kubectl and knative
  • Ensure that the tests are launched for PRs
  • Install the latest version of the tool yq to make that we have the same version on both OS and thus the same arguments
  • Avoid using the syntax ${INPUT_REGISTRY,,} for lowercase as it is only supported on bash 4 and MacOS still uses v3
  • Install docker when needed thanks to a dedicated bash function
  • Re-use the tee to update the file /etc/hosts since the workaround doesn't work properly and adapt it for both OS

@essobedo essobedo marked this pull request as ready for review February 8, 2023 15:15
@essobedo
Copy link
Contributor Author

essobedo commented Feb 8, 2023

@lburgazzoli @squakez If you can review it, it would great thx in advance 🙏

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just wonder why we need to install docker as it was working before without installing it, right?

@essobedo
Copy link
Contributor Author

essobedo commented Feb 8, 2023

LGTM. I just wonder why we need to install docker as it was working before without installing it, right?

Yes, it is needed, docker is not installed by default on MacOS runners due to a License issue but it is installed on Linux runners.

@essobedo
Copy link
Contributor Author

essobedo commented Feb 8, 2023

@squakez If it is ok for you, would you mind merging it?

@squakez squakez merged commit b53ad9c into container-tools:main Feb 9, 2023
@essobedo essobedo deleted the upgrade-kind-and-kubectl branch February 9, 2023 09:45
@essobedo
Copy link
Contributor Author

essobedo commented Feb 9, 2023

@squakez thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants