Skip to content

Commit

Permalink
Change required capability for published_node_ids in GetVolume
Browse files Browse the repository at this point in the history
Instead of PUBLISH_UNPUBLISH_VOLUME, use the LIST_VOLUMES_PUBLISHED_NODES
capability to control the published_node_ids field in ControllerGetVolume.
This change is to be more consistent with the existing behavior. It is
a backwards-incompatible change, but the API is alpha.
  • Loading branch information
bswartz committed Jul 21, 2021
1 parent 486e6bd commit 3d692ba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion csi.proto
Original file line number Diff line number Diff line change
Expand Up @@ -922,7 +922,7 @@ message ControllerGetVolumeResponse {
// A list of all the `node_id` of nodes that this volume is
// controller published on.
// This field is OPTIONAL.
// This field MUST be specified if the PUBLISH_UNPUBLISH_VOLUME
// This field MUST be specified if the LIST_VOLUMES_PUBLISHED_NODES
// controller capability is supported.
// published_node_ids MAY include nodes not published to or
// reported by the SP. The CO MUST be resilient to that.
Expand Down
2 changes: 1 addition & 1 deletion spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -1553,7 +1553,7 @@ message ControllerGetVolumeResponse {
// A list of all the `node_id` of nodes that this volume is
// controller published on.
// This field is OPTIONAL.
// This field MUST be specified if the PUBLISH_UNPUBLISH_VOLUME
// This field MUST be specified if the LIST_VOLUMES_PUBLISHED_NODES
// controller capability is supported.
// published_node_ids MAY include nodes not published to or
// reported by the SP. The CO MUST be resilient to that.
Expand Down

0 comments on commit 3d692ba

Please sign in to comment.