Skip to content

V6 builder#83

Open
constantoine wants to merge 9 commits intov6_rewritefrom
v6_builder
Open

V6 builder#83
constantoine wants to merge 9 commits intov6_rewritefrom
v6_builder

Conversation

@constantoine
Copy link
Owner

Replace Totp::new and the likes with a builder pattern

Signed-off-by: Cléo Rebert <cleo.rebert@ovhcloud.com>
Signed-off-by: Cléo Rebert <cleo.rebert@ovhcloud.com>
Signed-off-by: Cléo Rebert <cleo.rebert@ovhcloud.com>
Signed-off-by: Cléo Rebert <cleo.rebert@ovhcloud.com>
Signed-off-by: Cléo Rebert <cleo.rebert@ovhcloud.com>
@constantoine constantoine self-assigned this Mar 10, 2026
@constantoine constantoine added this to the v6 milestone Mar 10, 2026
Signed-off-by: Cléo Rebert <cleo.rebert@ovhcloud.com>
Signed-off-by: Cléo Rebert <cleo.rebert@ovhcloud.com>
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 93.57977% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.05%. Comparing base (c87d21e) to head (82f5f8e).

Files with missing lines Patch % Lines
src/algorithm.rs 48.64% 19 Missing ⚠️
src/url.rs 91.74% 9 Missing ⚠️
src/lib.rs 95.00% 3 Missing ⚠️
src/error.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           v6_rewrite      #83      +/-   ##
==============================================
- Coverage       93.26%   93.05%   -0.21%     
==============================================
  Files               6        8       +2     
  Lines            1128     1094      -34     
==============================================
- Hits             1052     1018      -34     
  Misses             76       76              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@constantoine
Copy link
Owner Author

constantoine commented Mar 11, 2026

TODO: Backport fixes from #82 before merging

Done

Signed-off-by: Cléo Rebert <cleo.rebert@ovhcloud.com>
Signed-off-by: Cléo Rebert <cleo.rebert@ovhcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant