Some features added #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added function to resolve an issue in Api Added function to reopen an issue in Api Added function to delete watchers in Api Added function to delete comments in Api Added function to delete attachments in Api
|
Not sure if it's a good idea to hardcode any transition-specific actions in general API class. Since in JIRA workflow and transition names can be customized then for some users such call might end up with error. Better to have universal transition method, that would accept:
|
|
I've changed my mind. Please rebase this and it can be merged. We can later refactor to remove duplicate transition finding code code and make actual transition names customizable. |
|
Please rebase and solve conflicts. |
| @@ -82,6 +82,8 @@ public function sendRequest($method, $url, $data = array(), $endpoint, Authentic | |||
| } else { | |||
| curl_setopt($curl, CURLOPT_POSTFIELDS, json_encode($data)); | |||
| } | |||
| } else if($method == "DELETE") { | |||
There was a problem hiding this comment.
This is already addressed in #76.
|
Planning on rebasing this myself if original author does not want to after #137 is finished. (Especially the remove methods are notable missing from current API) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Delete in CurlClient
Added function to resolve an issue in Api
Added function to reopen an issue in Api
Added function to delete watchers in Api
Added function to delete comments in Api
Added function to delete attachments in Api