Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send trailing "?" in GET API urls without parameters #245

Conversation

aik099
Copy link
Member

@aik099 aik099 commented Jan 25, 2025

No description provided.

@aik099 aik099 added this to the v2.0.0 milestone Jan 25, 2025
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.99%. Comparing base (cc6f50b) to head (571e2e2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #245   +/-   ##
=========================================
  Coverage     84.99%   84.99%           
- Complexity      211      213    +2     
=========================================
  Files            10       10           
  Lines           693      693           
=========================================
  Hits            589      589           
  Misses          104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aik099 aik099 merged commit c07c4d0 into console-helpers:master Jan 25, 2025
12 checks passed
@aik099 aik099 deleted the trailing-question-mark-in-get-requests-fix branch January 25, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant