Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the "Api:downloadAttachment" method + added tests #240

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

aik099
Copy link
Member

@aik099 aik099 commented Jan 9, 2025

Closes #234

@aik099 aik099 added this to the v2.0.0 milestone Jan 9, 2025
@aik099 aik099 added the type-bug label Jan 9, 2025
@aik099 aik099 force-pushed the download-attachment-test branch from 561b80a to 5b2f003 Compare January 9, 2025 19:09
@aik099 aik099 force-pushed the download-attachment-test branch from 5b2f003 to faa1474 Compare January 9, 2025 19:11
@aik099 aik099 merged commit 8eb4c61 into console-helpers:master Jan 9, 2025
10 checks passed
@aik099 aik099 deleted the download-attachment-test branch January 9, 2025 19:13
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.42%. Comparing base (52b5bd6) to head (faa1474).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #240      +/-   ##
============================================
+ Coverage     64.62%   66.42%   +1.79%     
- Complexity      207      208       +1     
============================================
  Files            10       10              
  Lines           687      691       +4     
============================================
+ Hits            444      459      +15     
+ Misses          243      232      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Api::downloadAttachment" method doesn't work with "CurlClient"
1 participant