Code

[Feature] Spender permit feature#110

Code

Open

charlesjhongc wants to merge 60 commits intomasterconsenlabs/tokenlon-contracts:masterfrom spender_permit_featureconsenlabs/tokenlon-contracts:spender_permit_featureCopy head branch name to clipboard

Commits

Commits on Oct 19, 2022

• feat: spender contract and foundry test

  Show description for d1d0156
  oneleo

  committed
  d1d0156

  Copy full SHA for d1d0156

• Merge branch 'master' into LABS-960/rfq-with-spender-permit

  oneleo

  committed
  93833a5

  Copy full SHA for 93833a5

Commits on Oct 24, 2022

• bug: change to new signature format

  Show description for ecbe62e
  oneleo

  committed
  ecbe62e

  Copy full SHA for ecbe62e

• feat: replace rfq spendfromuser func with spendfromusertowithpermit

  Show description for b05f0ec
  oneleo

  committed
  b05f0ec

  Copy full SHA for b05f0ec

Commits on Oct 26, 2022

• refac: leverage struct spendwithpermit in params

  Show description for a05cfcd
  oneleo

  committed
  a05cfcd

  Copy full SHA for a05cfcd

• chg: modify variable names for readability

  oneleo

  committed
  eae8717

  Copy full SHA for eae8717

• refac: move require condition from rfq to spender contract

  Show description for d89c922
  oneleo

  committed
  d89c922

  Copy full SHA for d89c922

• refac: modify variables and function in rfq foundry test

  Show description for 89c376a
  oneleo

  committed
  89c376a

  Copy full SHA for 89c376a

• chg: modify variable names for readability

  oneleo

  committed
  8af0b60

  Copy full SHA for 8af0b60

• spec: Add requester verification foundry test

  Show description for b5b3793
  oneleo

  committed
  b5b3793

  Copy full SHA for b5b3793

• refac: leverage struct spendwithpermit in params

  Show description for b2f296b
  oneleo

  committed
  b2f296b

  Copy full SHA for b2f296b

• bug: assign replay protection check before sig valid check

  Show description for 9dca7b1
  oneleo

  committed
  9dca7b1

  Copy full SHA for 9dca7b1

• bug: use safeTransfer() in SafeERC20 instead

  oneleo

  committed
  c376229

  Copy full SHA for c376229

• feat: remove taker/maker spendWithPermit but create they from _order

  Show description for 2d21eaa
  oneleo

  committed
  2d21eaa

  Copy full SHA for 2d21eaa

• refac: convert the BPS_MAX variable appropriately

  oneleo

  committed
  d493f7c

  Copy full SHA for d493f7c

Commits on Oct 27, 2022

• refac: move taker/maker spendWithPermit from fill() to _settle()

  Show description for 31ad782
  oneleo

  committed
  31ad782

  Copy full SHA for 31ad782

• feat: modify error message returned when replay protection checks

  Show description for ac38d3e
  oneleo

  committed
  ac38d3e

  Copy full SHA for ac38d3e

• refac: use only libconstant.bps_max variable

  Show description for 123e7df
  oneleo

  committed
  123e7df

  Copy full SHA for 123e7df

• chg: run prettier to format spender.sol to resolve code style issues

  oneleo

  committed
  c310fa1

  Copy full SHA for c310fa1

• Merge pull request #99 from consenlabs/LABS-940/spender-adds-backward-compatible-permit-function

  Show description for 556ddc7
  oneleo

  authored
  556ddc7

  Copy full SHA for 556ddc7

• Merge branch 'master' into modify-salt-usage-of-spendwithpermit

  oneleo

  committed
  65d0d60

  Copy full SHA for 65d0d60

Commits on Oct 28, 2022

• feat: spendWithPermit should contain transaction or order hash

  Show description for 9f242b9
  oneleo

  committed
  9f242b9

  Copy full SHA for 9f242b9

• Merge branch 'master' into spender_permit_feature

  oneleo

  committed
  45e146f

  Copy full SHA for 45e146f

• Merge branch 'spender_permit_feature' into modify-salt-usage-of-spendwithpermit

  oneleo

  committed
  049cda6

  Copy full SHA for 049cda6

Commits on Oct 31, 2022

• Merge pull request #105 from consenlabs/modify-salt-usage-of-spendwithpermit

  Show description for 8acfb68
  oneleo

  authored
  8acfb68

  Copy full SHA for 8acfb68

Commits on Nov 4, 2022

• Merge branch 'master' into spender_permit_feature

  oneleo

  committed
  c8b8f2d

  Copy full SHA for c8b8f2d

• feat: spendWithPermit should contain transaction or order hash

  Show description for 2a5da3d
  oneleo

  committed
  2a5da3d

  Copy full SHA for 2a5da3d

Commits on Nov 7, 2022

• Merge pull request #111 from consenlabs/modify-txhash-name-of-spendwithpermit

  Show description for 36d2730
  charlesjhongc

  authored
  36d2730

  Copy full SHA for 36d2730

• refac: rfq, spender contracts changed to non named parameter type

  Show description for db4726e
  oneleo

  committed
  db4726e

  Copy full SHA for db4726e

• Merge branch 'master' into spender_permit_feature

  oneleo

  committed
  db1564a

  Copy full SHA for db1564a

Commits on Nov 8, 2022

• Merge pull request #112 from consenlabs/rfq_spender_to_no_named_parameter

  Show description for 03d5b72
  oneleo

  authored
  03d5b72

  Copy full SHA for 03d5b72

Commits on Nov 9, 2022

• refac: move the signSpendWithPermit function in foundry test

  Show description for 77fb55a
  oneleo

  committed
  77fb55a

  Copy full SHA for 77fb55a

• perf: use eip712 domain separator instead of spender contract

  Show description for 5627a14
  oneleo

  committed
  5627a14

  Copy full SHA for 5627a14

• bug: revert when sigType is invalid

  oneleo

  committed
  b9f4bac

  Copy full SHA for b9f4bac

Commits on Nov 10, 2022

• modify spendFromUser --> spendFromUserToWithPermit

  

  david_tsai

  committed
  9a1d452

  Copy full SHA for 9a1d452

• add helper function regarding spenderPermit on l2Deposit action

  

  david_tsai

  committed
  a130849

  Copy full SHA for a130849

• modify test case using spenderPermit

  

  david_tsai

  committed
  f17e7ab

  Copy full SHA for f17e7ab

• replace comment for _createSpenderPermitFromL2Deposit

  

  david_tsai

  committed
  0714df3

  Copy full SHA for 0714df3

• remove accidentally added files

  

  david_tsai

  committed
  c3377c7

  Copy full SHA for c3377c7

• remove redundant comments

  

  david_tsai

  committed
  f02e23a

  Copy full SHA for f02e23a

Commits on Nov 11, 2022

• fix nit

  

  david_tsai

  committed
  4dd27c9

  Copy full SHA for 4dd27c9

• modify solidity objects using named parameters

  

  david_tsai

  committed
  7b4392e

  Copy full SHA for 7b4392e

• modify DEFAULT_DEPOSIT to _deposit in _createSpenderPermitFromL2Deposit

  

  david_tsai

  committed
  be48682

  Copy full SHA for be48682

• Merge pull request #114 from consenlabs/move_signspendwithpermit_func

  Show description for b66e418
  oneleo

  authored
  b66e418

  Copy full SHA for b66e418

• feat: replace amm spendfromuser func with spendfromusertowithpermit

  Show description for 6bdf206
  oneleo

  committed
  6bdf206

  Copy full SHA for 6bdf206

• chg: modify variable name to match internal variable format

  Show description for a52be1c
  oneleo

  committed
  a52be1c

  Copy full SHA for a52be1c

Commits on Nov 14, 2022

• Merge branch 'spender_permit_feature' into modify-l2deposit-using-spenderFromUserWithPermit

  Show description for 7150101
  

  david_tsai

  committed
  7150101

  Copy full SHA for 7150101

• remove signSpendWithPermit() from Setup.t.sol

  

  david_tsai

  committed
  a0e582e

  Copy full SHA for a0e582e

• use signSpendWithPermit() from contracts-test/utils/Permit.sol

  

  david_tsai

  committed
  4130802

  Copy full SHA for 4130802

• refec: modify comments and function names

  Show description for 58d1b78
  oneleo

  committed
  58d1b78

  Copy full SHA for 58d1b78

• Merge pull request #115 from consenlabs/modify-l2deposit-using-spenderFromUserWithPermit

  Show description for 4aa11d0
  108356037

  authored
  4aa11d0

  Copy full SHA for 4aa11d0

• refec: modify comments and remove unused imported package

  Show description for eb9ca88
  oneleo

  committed
  eb9ca88

  Copy full SHA for eb9ca88

Commits on Nov 15, 2022

• doc: adject _transferTakerAssetToAMM func comment to be clearer

  oneleo

  committed
  66b606f

  Copy full SHA for 66b606f

• doc: use named parameters to make code clearer

  Show description for 2619aca
  oneleo

  committed
  2619aca

  Copy full SHA for 2619aca

• doc: apply named parameters to transferTakerAssetToAMM in ammwrapper

  oneleo

  committed
  6c542db

  Copy full SHA for 6c542db

• Merge pull request #116 from consenlabs/amm-with-spender-permit

  Show description for 424feec
  oneleo

  authored
  424feec

  Copy full SHA for 424feec

Commits on Nov 16, 2022

• refac: handle the conflict between RFQ.t.sol and the master branch

  oneleo

  committed
  a67eba2

  Copy full SHA for a67eba2

• Merge branch 'master' into spender_permit_feature

  oneleo

  authored
  e8b9284

  Copy full SHA for e8b9284

• feat: remove spendFromUser() func in Spender.sol

  Show description for 8dcef47
  oneleo

  committed
  8dcef47

  Copy full SHA for 8dcef47

Commits on Feb 8, 2023

• Merge pull request #119 from consenlabs/remove_spendfromuser_function

  Show description for d1e7f20
  charlesjhongc

  authored
  d1e7f20

  Copy full SHA for d1e7f20