Skip to content

Commit

Permalink
#207 Migrate footer code to core react component
Browse files Browse the repository at this point in the history
  • Loading branch information
conorheffron committed Jan 4, 2025
1 parent 7094f81 commit 9fed36d
Show file tree
Hide file tree
Showing 9 changed files with 27 additions and 5 deletions.
8 changes: 4 additions & 4 deletions frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion frontend/public/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,4 @@
<noscript>You need to enable JavaScript to run this app.</noscript>
<div id="root"></div>
</body>
<footer><p>© 2017 by Conor Heffron</p></footer>
</html>
11 changes: 11 additions & 0 deletions frontend/src/Footer.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { Container } from 'reactstrap';

export default function Footer() {
return (
<div className="App">
<Container>
<footer><p>© 2017 by Conor Heffron</p></footer>
</Container>
</div>
);
}
2 changes: 2 additions & 0 deletions frontend/src/components/About.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React, { Component } from 'react';
import { Container } from 'reactstrap';
import '.././App.css';
import AppNavbar from '.././AppNavbar';
import Footer from '.././Footer';

class About extends Component {

Expand Down Expand Up @@ -29,6 +30,7 @@ class About extends Component {
</a>
</header>
</Container>
<Footer/>
</div>
);
}
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/components/ControlledCarousel.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import 'bootstrap/dist/css/bootstrap.css';
import '.././App.css';
import { Container } from 'reactstrap';
import AppNavbar from '.././AppNavbar';
import Footer from '.././Footer';
import navy from '.././img/darkblue-bg.png';
import teal from '.././img/teal-bg.png';
import red from '.././img/red-bg.png';
Expand Down Expand Up @@ -103,6 +104,7 @@ class ControlledCarousel extends Component {
</Carousel.Item>
</Carousel>
</Container>
<Footer/>
</div>
);
}
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/components/Home.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React, { Component } from 'react';
import { Container } from 'reactstrap';
import '.././App.css';
import AppNavbar from '.././AppNavbar';
import Footer from '.././Footer';
import logo from '.././img/robot-logo.png';

class Home extends Component {
Expand All @@ -16,6 +17,7 @@ class Home extends Component {
<p id="my-intro">Web Application Development | Software & Data Engineering | DevOps</p>
</header>
</Container>
<Footer/>
</div>
);
}
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/components/NotFound.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React, { Component } from 'react';
import { Container } from 'reactstrap';
import '.././App.css';
import AppNavbar from '.././AppNavbar';
import Footer from '.././Footer';

class NotFound extends Component {

Expand All @@ -15,6 +16,7 @@ class NotFound extends Component {
<p id="my-intro">Sorry, the page you are looking for could not be found.</p>
</header>
</Container>
<Footer/>
</div>
);
}
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/components/RepoDetails.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { Button, ButtonGroup, Container, InputGroup, Table } from 'reactstrap';
import '.././App.css';
import Form from 'react-bootstrap/Form';
import AppNavbar from '.././AppNavbar';
import Footer from '.././Footer';
import { Link } from 'react-router-dom';

class RepoDetails extends Component {
Expand Down Expand Up @@ -82,6 +83,7 @@ class RepoDetails extends Component {
<tbody>{repoList}</tbody>
</Table>
</Container>
<Footer/>
</div>
);
}
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/components/RepoIssues.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { Button, Container, InputGroup, Table } from 'reactstrap';
import '.././App.css';
import Form from 'react-bootstrap/Form';
import AppNavbar from '.././AppNavbar';
import Footer from '.././Footer';

class RepoIssues extends Component {

Expand Down Expand Up @@ -75,6 +76,7 @@ class RepoIssues extends Component {
<tbody>{repoList}</tbody>
</Table>
</Container>
<Footer/>
</div>
);
}
Expand Down

0 comments on commit 9fed36d

Please sign in to comment.