fix: adapter support added #5221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathmeshkhandelwal1
requested review from
just-a-node and
rhlsthrm
as code owners
just-a-node
reviewed
Dec 1, 2023
packages/agents/sdk/src/sdkShared.ts
Outdated
| const isXERC20 = await xerc20Registry.functions.isXERC20(tokenAddress); | ||
| if (isXERC20) { | ||
| const lockbox = await xerc20Registry.functions.getLockbox(tokenAddress); | ||
| if (lockbox !== "0x0000000000000000000000000000000000000000") { |
There was a problem hiding this comment.
we can use constants.AddressZero
There was a problem hiding this comment.
remved this
just-a-node
reviewed
Dec 1, 2023
packages/agents/sdk/src/sdkBase.ts
Outdated
| @@ -228,7 +228,17 @@ export class SdkBase extends SdkShared { | |||
| }); | |||
| } | |||
|
|
|||
| const connextContractAddress = (await this.getConnext(origin, options)).address; | |||
| const isValidAsset = await this.hasLockbox(origin, asset, options); | |||
There was a problem hiding this comment.
let's name this something more specfic, like isValidLockboxAsset
There was a problem hiding this comment.
removed this whole logic
just-a-node
previously approved these changes
Dec 1, 2023
prathmeshkhandelwal1
requested review from
preethamr,
liu-zhipeng and
wanglonghong
as code owners
just-a-node
approved these changes
Dec 18, 2023
liu-zhipeng
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a feature to automate lockbox adapter process while dealing with xERC20 assets in
xcall.Type of change
High-level change(s) description - from the user's perspective
Related Issue(s)
Fixes: #5154
Related pull request(s)