Repository navigation
benches: clone the server_stream payload once per item - #327
Merged
Merged
Conversation
The server_stream handlers in benches/rpc and benches/rpc-tonic cloned the payload before checking the bound, so the terminating poll of `unfold` made one more deep copy than the stream had items: 11 for the 10-message benchmark. Carry the payload in the `unfold` state and clone after the check, as benches/rpc-grpc-rust already does. Signed-off-by: Iain McGinniss <309153+iainmcgin@users.noreply.github.com>
iainmcgin
marked this pull request as ready for review
October 3, 2026 22:24
iainmcgin
enabled auto-merge
October 3, 2026 22:24
azdagron
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
server_streamhandlers inbenches/rpcandbenches/rpc-toniccloned the payload before checking the bound, so the terminating poll ofunfoldmade one more deep copy than the stream had items: 11 for the 10-message benchmark. The payload now travels in theunfoldstate and is cloned after the check, asbenches/rpc-grpc-rustalready does.The README's
server_stream (10 messages)row was measured with the extra clone in the connectrpc-rs and tonic columns and without it in tonic-protobuf; the published numbers are unchanged here and are due a re-measure at the next benchmark refresh.