Repository navigation
Add support for Python 3.15 and remove 3.10 - #390
Merged
Merged
Conversation
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
anuraaga
commented
Oct 9, 2026
|
|
||
| ### Prerequisites | ||
|
|
||
| - Python 3.10 or later |
Collaborator
Author
There was a problem hiding this comment.
Since uv will provision it actually I don't think this is a prereq
|
|
||
| [tool.ruff.lint] | ||
| typing-extensions = false | ||
| typing-extensions = true |
Collaborator
Author
There was a problem hiding this comment.
We could have done this before, doing it now
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
anuraaga
commented
Oct 9, 2026
| @@ -1,51 +1,12 @@ | |||
| from __future__ import annotations | |||
|
|
|||
| import grpc | |||
Collaborator
Author
There was a problem hiding this comment.
grpc python still doesn't support free-threaded python while connect-py does with full compatibility with gRPC.
I went ahead and just removed this rather than trying to sort something out since conformance verifies compatibility with grpc-go which should be enough
stefanvanburen
approved these changes
Oct 9, 2026
| @@ -3,7 +3,7 @@ name = "connectrpc-grpcreflect" | |||
| version = "0.1.0" | |||
| description = "gRPC reflection for connectrpc" | |||
Member
There was a problem hiding this comment.
maybe a follow up: the top-level calls it "Connect RPC"; these are all "connectrpc" in the description. not sure if we want them to match or if deliberate to match the top-level module name.
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
stefanvanburen
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3.15 out soon and 3.10 is already EOL. We've also never tested free-threaded python so good to test that, there's nothing we do that would break with it.
All of the code changes are automatic by ruff