Skip to content

Lazy import pyqwest.Headers for gRPC-web #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anuraaga merged 1 commit into from
Oct 8, 2026
Merged

Lazy import pyqwest.Headers for gRPC-web #386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/connectrpc/_protocol_grpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
from http import HTTPStatus
from typing import TYPE_CHECKING, Any, TypeVar

from pyqwest import Headers as HTTPHeaders

from ._compression import IdentityCompression, negotiate_compression
from ._envelope import EnvelopeReader, EnvelopeWriter
from ._gen.google.rpc.status_pb import Status
Expand All @@ -27,7 +25,7 @@
if TYPE_CHECKING:
from collections.abc import Mapping

from pyqwest import Response, SyncResponse
from pyqwest import Headers as HTTPHeaders, Response, SyncResponse

from ._codec import Codec
from ._compression import Compression
Expand Down Expand Up @@ -412,6 +410,10 @@ def __init__(
read_max_bytes: int | None,
) -> None:
super().__init__(message_class, codec, compression, read_max_bytes)

# We lazy import to avoid eagerly importing the client for server-only code.
from pyqwest import Headers as HTTPHeaders # noqa: PLC0415

self._trailers = HTTPHeaders()

def handle_end_message(
Expand Down
Loading