Repository navigation
Test the typing_extensions floor in lowest-direct CI - #350
Merged
Merged
Conversation
The `dev` group pinned `typing_extensions==4.16.0`, so the `lowest-direct` CI legs resolved 4.16.0 instead of the `>=4.13.0` floor that `connectrpc` declares. Dropping the pin lets `lowest-direct` install 4.13.0; `highest` still locks 4.16.0. Signed-off-by: Stefan VanBuren <stefan@vanburen.xyz>
stefanvanburen
marked this pull request as ready for review
September 25, 2026 01:21
anuraaga
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
devgroup pinnedtyping_extensions==4.16.0, andlowest-directpicks the lowest version satisfying every direct constraint, so CI never tested the>=4.13.0floor. With the pin gone,lowest-directinstalls 4.13.0; locallypoe test,poe test-otel, andpoe test-grpcreflectpass against it.higheststill locks 4.16.0. Found while reviewing #348, which has the same issue with itsanyioandtriopins.