Fix predictable gateway API keys - #411
Merged
akordavid373 merged 1 commit intoAug 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #384. Summary: replaces Math.random-based gateway API key creation with APIKeyManager-backed crypto keys, redacts stored key hashes from API responses, wires list/revoke endpoints to the real manager, passes request context into gateway key validation, and adds per-key rate-limit/revocation coverage. Verification: npm test -- --runTestsByPath src/gateway/tests/APIKeyManager.test.ts --runInBand; npx eslint src/gateway/APIKeyManager.ts src/gateway/PrivacyApiGateway.ts src/routes/gateway.ts src/gateway/tests/APIKeyManager.test.ts; npx prettier --check src/gateway/APIKeyManager.ts src/gateway/PrivacyApiGateway.ts src/routes/gateway.ts src/gateway/tests/APIKeyManager.test.ts. Also ran npm run type-check; it exits via the repo's non-blocking script but still reports pre-existing unrelated repo-wide errors such as missing @stellar/shared and existing worker/service type issues.