-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DGS-11414: add pagination for get all subjects #3455
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge. |
This comment has been minimized.
This comment has been minimized.
0c4a776
to
29b3bf4
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @djibodu , left some comments
core/src/main/java/io/confluent/kafka/schemaregistry/storage/KafkaSchemaRegistry.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/confluent/kafka/schemaregistry/rest/resources/SubjectsResource.java
Outdated
Show resolved
Hide resolved
29b3bf4
to
d76b263
Compare
d76b263
to
692e7a0
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @djibodu , left some comments
client/src/main/java/io/confluent/kafka/schemaregistry/client/rest/RestService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/confluent/kafka/schemaregistry/storage/KafkaSchemaRegistry.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/confluent/kafka/schemaregistry/storage/KafkaSchemaRegistry.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/confluent/kafka/schemaregistry/storage/KafkaSchemaRegistry.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/confluent/kafka/schemaregistry/storage/SchemaRegistry.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/confluent/kafka/schemaregistry/rest/client/LocalSchemaRegistryClient.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @djibodu , LGTM
What
Adding pagination for getAllSubjects. Default and max limit both set to 20,000
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups