DPA-1718 Make cloudwatch enablement config driven #1735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Makes CloudWatch agent enablement configurable through a command-line parameter instead of being always enabled, allowing users to disable CloudWatch setup when not needed.
- Adds
--enable-cloudwatchcommand-line argument with boolean parsing to control CloudWatch activation - Implements conditional CloudWatch agent setup that skips installation when disabled
- Updates Packer configuration to pass the CloudWatch enablement flag and job ID as environment variables
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vagrant/cloudwatch-agent-setup.sh | Adds conditional logic to skip CloudWatch setup when ENABLE_CLOUDWATCH is false |
| vagrant/aws-packer.json | Adds environment variables for CloudWatch enablement and job ID, includes CloudWatch setup script |
| terraform/kafka_runner/util.py | Adds --enable-cloudwatch command-line argument with boolean type parsing |
| terraform/kafka_runner/run-test.py | Passes enable_cloudwatch and JOB_ID parameters to AMI creation function |
| parser.add_argument("--jdk-arch", action="store", type=str, default="x64", | ||
| help="JDK arch to execute."), | ||
| parser.add_argument("--nightly", action="store_true", default=False, help="Mark this as a nightly run") | ||
| parser.add_argument("--enable-cloudwatch", action="store", type=parse_bool, default=False, help="Enable cloudwatch metrics if true") |
There was a problem hiding this comment.
The parse_bool function is used but not defined or imported in this file. This will cause a NameError when the argument parser is used.
Copilot uses AI. Check for mistakes.
omkreddy
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.