-
Couldn't load subscription status.
- Fork 6
Add CUB extra path dirs #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add CUB extra path dirs #207
Conversation
…ASSPATH_DIRS environment variable
…ASSPATH_DIRS environment variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for extending the Java CLASSPATH in the CUB (Confluent Utility Belt) to resolve issues with SASL config providers during preflight validation. The change introduces a new CUB_CLASSPATH_DIRS environment variable that allows appending additional directories to the classpath without losing the default base paths.
Key changes:
- Introduces
CUB_CLASSPATH_DIRSenvironment variable with flexible delimiter support (:,;,,) - Adds automatic wildcard normalization for directory paths to include all JARs
- Maintains backward compatibility with existing
CUB_CLASSPATHandCUB_EXTRA_CLASSPATHvariables
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| confluent/docker_utils/cub.py | Core implementation of classpath building logic with new environment variable support |
| test/test_classpath.py | Comprehensive unit tests covering various classpath scenarios and edge cases |
| docs/CHANGELOG.rst | Documents the new feature in the unreleased section |
| README.md | Adds detailed documentation and usage examples for the new classpath functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
check only linux file separator Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Change Description
-- Overriding CUB_CLASSPATH like /usr/share/java/cp-base-new/*:PATH_TO_CONFIG_PROVIDER_JARS
-- Copying the config provider jars inside /usr/share/java/cp-base-new/
check issue #111
Testing
unit tests created at
test/test_classpath.py