Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove packer docs and files for azure #2234

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkulke
Copy link
Collaborator

@mkulke mkulke commented Jan 13, 2025

The azrue build-image instructions have been updated for mkosi podvms.

Since we don't test packer images for azure anymore, we should remove it here, it's likely that there is a version drift and the resulting images won't work as expected anymore.

@mkulke mkulke requested a review from a team as a code owner January 13, 2025 10:58
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks!

@mkulke mkulke force-pushed the mkulke/remove-azure-packer-instructions branch from 5fabef0 to 9f8f3d6 Compare January 13, 2025 11:07
The azrue build-image instructions have been updated for mkosi podvms.

Since we don't test packer images for azure anymore, we should remove it
here, it's likely that there is a version drift and the resulting images
won't work as expected anymore.

Signed-off-by: Magnus Kulke <[email protected]>
@mkulke mkulke force-pushed the mkulke/remove-azure-packer-instructions branch from 9f8f3d6 to 5a8c81f Compare January 13, 2025 11:39
@snir911
Copy link
Contributor

snir911 commented Jan 13, 2025

Would it make sense to add a note indicates this is about to be deprecated and plan to deprecate it in the next release? Or perhaps start by removing the documentation while keeping the code for an additional release? it’s still being used by OCP.

@mkulke
Copy link
Collaborator Author

mkulke commented Jan 13, 2025

Would it make sense to add a note indicates this is about to be deprecated and plan to deprecate it in the next release? Or perhaps start by removing the documentation while keeping the code for an additional release? it’s still being used by OCP.

I see, we can add a note and leave the existing packer code in place for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants