Skip to content

Letting Memory Cache takes care of the locks cause of concurrent requ… #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Letting Memory Cache takes care of the locks cause of concurrent requ… #115

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0c212b
Letting Memory Cache takes care of the locks cause of concurrent requ…
paulcaru Apr 18, 2024
20e0065
Locking Mechanism on getting the token for concurrent requests
paulcaru Apr 19, 2024
ea7dbdf
Locking Mechanism on getting the token for concurrent requests
paulcaru Apr 19, 2024
caaf3b6
Merge branch 'conductor-sdk:main' into main
paulcaru May 14, 2024
99cbe1a
merging and recommiting
paulcaru May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Conductor/Client/Authentication/TokenHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ public class TokenHandler
{
private static int REFRESH_TOKEN_RETRY_COUNTER_LIMIT = 5;
private static readonly object _lockObject = new object();
private static readonly object _getTokenlockObject = new object();
private readonly MemoryCache _memoryCache;
private static ILogger _logger;

Expand All @@ -18,15 +19,19 @@ public TokenHandler()
_memoryCache = new MemoryCache(new MemoryCacheOptions());
_logger = ApplicationLogging.CreateLogger<TokenHandler>();
}

public string GetToken(OrkesAuthenticationSettings authenticationSettings, TokenResourceApi tokenClient)
{
string token = (string)_memoryCache.Get(authenticationSettings);
if (token != null)
{
return token;
}
return RefreshToken(authenticationSettings, tokenClient);

lock (_getTokenlockObject)
Copy link
Contributor

@IvanKulik-sm IvanKulik-sm Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this should be used:

string token = _memoryCache.GetOrCreate(authenticationSettings, entry =>
{
    entry.AbsoluteExpirationRelativeToNow = TimeSpan.FromMinutes(30);
    
    return GetTokenFromServer(authenticationSettings, tokenClient);
});

{
token = (string)_memoryCache.Get(authenticationSettings);
return token != null ? token : RefreshToken(authenticationSettings, tokenClient);
}
}

public string RefreshToken(OrkesAuthenticationSettings authenticationSettings, TokenResourceApi tokenClient)
Expand Down